Skip to content

Conversation

@jbertram
Copy link
Contributor

This commit does the following:

  • Allows lastDeliveredTime and lastAcknowledgedTime to be filtered via the management API.
  • Adds unit tests for all such attributes to verify they are filterable.
  • Looks up the correct value on the server when filtering on messagesDelivered.
  • Breaks up ViewTest into corresponding classes so all attributes can be unit tested eventually.

@jbertram jbertram force-pushed the ARTEMIS-5854 branch 2 times, most recently from 559213b to d055f97 Compare January 27, 2026 15:52
@tabish121
Copy link
Contributor

I ran this in CI and the follow tests failed:

Run / Test / 4 / org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlTest.testListConsumersLastDeliveredTime() legacyCreateQueue=true
Run / Test / 4 / org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlTest.testListConsumersLastDeliveredTime() legacyCreateQueue=false
Run / Test / 0 / org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlUsingCoreTest.testListConsumersLastDeliveredTime() legacyCreateQueue=true
Run / Test / 0 / org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlUsingCoreTest.testListConsumersLastDeliveredTime() legacyCreateQueue=false
Run / Test / 0 / org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlUsingCoreTest.testListConsumersLastAckTime() legacyCreateQueue=true
Run / Test / 0 / org.apache.activemq.artemis.tests.integration.management.ActiveMQServerControlUsingCoreTest.testListConsumersLastAckTime() legacyCreateQueue=false

This commit does the following:

 - Allows `lastDeliveredTime` and `lastAcknowledgedTime` to be filtered
   via the management API.
 - Adds unit tests for all such attributes to verify they are
   filterable.
 - Looks up the correct value on the server when filtering on
   `messagesDelivered`.
 - Breaks up `ViewTest` into corresponding classes so all attributes can
   be unit tested eventually.
@jbertram jbertram force-pushed the ARTEMIS-5854 branch 5 times, most recently from 736393d to f79a972 Compare February 2, 2026 01:42
@jbertram
Copy link
Contributor Author

jbertram commented Feb 2, 2026

The test issues should be sorted now.

@tabish121 tabish121 merged commit d657f96 into apache:main Feb 2, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants