ARTEMIS-5911 Ensure core federation ignores AMQP federation configura…#6249
Open
tabish121 wants to merge 1 commit intoapache:mainfrom
Open
ARTEMIS-5911 Ensure core federation ignores AMQP federation configura…#6249tabish121 wants to merge 1 commit intoapache:mainfrom
tabish121 wants to merge 1 commit intoapache:mainfrom
Conversation
tabish121
force-pushed
the
ARTEMIS-5911
branch
from
42fa3fc to
40c9259
Compare
…tion When parsing the Core federation XML elements we need to ensure that AMQP broker connections with federation configuration does not get picked up as that creates empty configuration entries in the broker configuration.
tabish121
force-pushed
the
ARTEMIS-5911
branch
from
40c9259 to
ee98a00
Compare
gemmellr
reviewed
Feb 25, 2026
Comment on lines
+673
to
+677
| final FederationConfiguration configuration2 = federations.get("federation3"); | ||
|
|
||
| assertEquals(2, configuration2.getUpstreamConfigurations().size()); | ||
| assertEquals(0, configuration2.getDownstreamConfigurations().size()); | ||
| assertEquals(1, configuration2.getTransformerConfigurations().size()); |
Member
There was a problem hiding this comment.
C&P error? Looks to be checking the wrong config, federation3 instead of federation2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion
When parsing the Core federation XML elements we need to ensure that AMQP broker connections with federation configuration does not get picked up as that creates empty configuration entries in the broker configuration.