Merged
Conversation
| return send(getCurrentTransaction(), message, direct, noAutoCreateQueue); | ||
| } | ||
|
|
||
| @Override |
Contributor
There was a problem hiding this comment.
There is a way to avoid these on compile time, using Error Prone.
I have tried that, and I even had the changes... but we have some code generated.. we would need to ignore the generated code, or to make it also have overrides.
@scop Can we talk through IRC tomorrow, or google chat?
Contributor
Author
There was a problem hiding this comment.
@clebertsuconic if you have your Error Prone changes still somewhere, maybe you can push them somewhere public, I'd be interested in taking a look?
Contributor
There was a problem hiding this comment.
@scop I just started my day but I guess you came up with the same changes :)
nice one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.