Skip to content

[ASTERIXDB-3021][COMP] Emit cross product warning for implicit joins #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pineappleBest123 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

[ASTERIXDB-3021][COMP] Emit cross product warning for implicit joins #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...src/main/java/org/apache/hyracks/algebricks/rewriter/rules/SimpleUnnestToProductRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
import org.apache.hyracks.algebricks.core.algebra.operators.logical.visitors.VariableUtilities;
import org.apache.hyracks.algebricks.core.algebra.util.OperatorPropertiesUtil;
import org.apache.hyracks.algebricks.core.rewriter.base.IAlgebraicRewriteRule;
import org.apache.hyracks.algebricks.rewriter.util.JoinUtils;

public class SimpleUnnestToProductRule implements IAlgebraicRewriteRule {

Expand Down Expand Up @@ -142,6 +143,8 @@ && descOrSelfIsSourceScan(currentOpRef.getValue())) {
context.computeAndSetTypeEnvironmentForOperator(boundaryOperator);
context.computeAndSetTypeEnvironmentForOperator(innerBranchOperator);
context.computeAndSetTypeEnvironmentForOperator(join);
JoinUtils.warnIfCrossProduct(join.getCondition().getValue(),
innerBranchOperator.getSourceLocation(), context);
return true;
}

Expand Down
2 changes: 1 addition & 1 deletion ...ebricks-rewriter/src/main/java/org/apache/hyracks/algebricks/rewriter/util/JoinUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ private static BuildSide getHashJoinBuildSide(ILogicalExpression e, List<Logical
return null;
}

private static void warnIfCrossProduct(ILogicalExpression conditionExpr, SourceLocation sourceLoc,
public static void warnIfCrossProduct(ILogicalExpression conditionExpr, SourceLocation sourceLoc,
IOptimizationContext context) {
if (OperatorPropertiesUtil.isAlwaysTrueCond(conditionExpr) && sourceLoc != null) {
IWarningCollector warningCollector = context.getWarningCollector();
Expand Down