ability to enable audits in SSL enabled cassandra backend#23
Open
chaitrarao04 wants to merge 1 commit intoapache:masterfrom
Open
ability to enable audits in SSL enabled cassandra backend#23chaitrarao04 wants to merge 1 commit intoapache:masterfrom
chaitrarao04 wants to merge 1 commit intoapache:masterfrom
Conversation
gmcoringa
reviewed
Jun 14, 2019
|
|
||
| Cluster cluster = null; | ||
| if (isSSLEnabled) { | ||
| if (StringUtils.isNotEmpty(username) && StringUtils.isNotEmpty(password)) { |
There was a problem hiding this comment.
User credentials should not be locked into ssl, there are scenarios where only authentication is enought.
| public static final String CASSANDRA_SSL_TRUSTSTORE_PASSWORD = "atlas.graph.storage.cassandra.ssl.truststore.password"; | ||
|
|
||
| // cassandra login credentials | ||
| public static final String CASSANDRA_USERNAME = "atlas.graph.storage.username"; |
There was a problem hiding this comment.
The user credentials could use different properties, so you can have different users for audit and atlas keyspaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing code in CassandraBasedAuditRepository can write audits only to cassandra that does not have SSL enabled and credentials setup.
The fix in this PR reads the truststore certificate location, truststore password, cassandra username, cassandra password from the application properties and establishes connection to cassandra over SSL. Thus enabling enabling audits to be persisted in SSL/Credentials enabled Cassandra datastore.