Skip to content

[ATLAS-3305] Allow to run multiple kafka consumers #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arempter wants to merge 1 commit into from
Closed

[ATLAS-3305] Allow to run multiple kafka consumers #63

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,14 +156,17 @@ public <T> List<NotificationConsumer<T>> createConsumers(NotificationType notifi
public <T> List<NotificationConsumer<T>> createConsumers(NotificationType notificationType, int numConsumers, boolean autoCommitEnabled) {
LOG.info("==> KafkaNotification.createConsumers(notificationType={}, numConsumers={}, autoCommitEnabled={})", notificationType, numConsumers, autoCommitEnabled);

Properties consumerProperties = getConsumerProperties(notificationType);
AtlasKafkaConsumer kafkaConsumer = new AtlasKafkaConsumer(notificationType, getKafkaConsumer(consumerProperties, notificationType, autoCommitEnabled), autoCommitEnabled, pollTimeOutMs);
List<NotificationConsumer<T>> consumers = new ArrayList<>();
for (int i = 0; i < numConsumers; i++) {
Properties consumerProperties = getConsumerProperties(notificationType);

List<NotificationConsumer<T>> consumers = Collections.singletonList(kafkaConsumer);
AtlasKafkaConsumer kafkaConsumer = new AtlasKafkaConsumer(notificationType, getKafkaConsumer(consumerProperties, notificationType, autoCommitEnabled), autoCommitEnabled, pollTimeOutMs);
consumers.add(kafkaConsumer);
}

LOG.info("<== KafkaNotification.createConsumers(notificationType={}, numConsumers={}, autoCommitEnabled={})", notificationType, numConsumers, autoCommitEnabled);

return consumers;
return Collections.unmodifiableList(consumers);
}

@Override
Expand Down Expand Up @@ -231,20 +234,17 @@ void sendInternalToProducer(Producer p, NotificationType type, List<String> mess


public KafkaConsumer getKafkaConsumer(Properties consumerProperties, NotificationType type, boolean autoCommitEnabled) {
if (consumer == null || !isKafkaConsumerOpen(consumer)) {
try {
String topic = TOPIC_MAP.get(type);
try {
String topic = TOPIC_MAP.get(type);

consumerProperties.put("enable.auto.commit", autoCommitEnabled);
consumerProperties.put("enable.auto.commit", autoCommitEnabled);

this.consumer = new KafkaConsumer(consumerProperties);
this.consumer = new KafkaConsumer(consumerProperties);

this.consumer.subscribe(Arrays.asList(topic));
} catch (Exception ee) {
this.consumer.subscribe(Arrays.asList(topic));
} catch (Exception ee) {
LOG.error("Exception in getKafkaConsumer ", ee);
}
}

return this.consumer;
}

Expand Down