Skip to content

Improve full_join.rs: move has_multi_equal out of loop #1695

@xumingming

Description

@xumingming

currently has_multi_equal is repeated set in loops, which is not necessary:

let mut has_multi_equal = false;
let mut l_equal = true;
let mut r_equal = true;
while l_equal && r_equal {
if l_equal {
l_equal = !cur1.finished() && cur1.cur_key() == cur1.key(l_key_idx);
if l_equal {
has_multi_equal = true;
equal_lindices.push(cur1.cur_idx());
cur_forward!(cur1);
}
}
if r_equal {
r_equal = !cur2.finished() && cur2.cur_key() == cur2.key(r_key_idx);
if r_equal {
has_multi_equal = true;
equal_rindices.push(cur2.cur_idx());
cur_forward!(cur2);
}
}
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions