[AURON-1245][FOLLOWUP] Restore commit hash in artifact name using git rev-parse#1246
Merged
cxzl25 merged 3 commits intoapache:masterfrom Sep 1, 2025
Merged
Conversation
merrily01
force-pushed
the
restore-commit-hash
branch
from
d9c3fc7 to
993a275
Compare
merrily01
changed the title
Member
|
add it for arm build as well? |
merrily01
force-pushed
the
restore-commit-hash
branch
from
993a275 to
a70a79d
Compare
Member
Author
Thanks for reminding， it has been also added to arm build. CI passed and ready for review : ce7 - https://github.com/apache/auron/actions/runs/17368783500 arm - https://github.com/apache/auron/actions/runs/17368783487 |
cxzl25
reviewed
Sep 1, 2025
merrily01
commented
Sep 1, 2025
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ github.event.pull_request.head.sha }} |
Member
Author
There was a problem hiding this comment.
I noticed that during the GA Docker build, the printed commit id comes from the merge commit generated by GitHub Actions, rather than the original commit that actually triggered the workflow. I'm trying to use the original commit ID here, so that the printed commit id matches the real source commit instead of the merge commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1245.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?