[AURON #1579]Implement native function of isnan(87),nv2(83) ,nvl(82) #1579#1581
Closed
guixiaowen wants to merge 3 commits intoapache:masterfrom
Closed
[AURON #1579]Implement native function of isnan(87),nv2(83) ,nvl(82) #1579#1581guixiaowen wants to merge 3 commits intoapache:masterfrom
guixiaowen wants to merge 3 commits intoapache:masterfrom
Conversation
guixiaowen
changed the title
guixiaowen
changed the title
# Conflicts: # native-engine/auron-serde/proto/auron.proto # spark-extension-shims-spark/src/test/scala/org/apache/spark/sql/auron/AuronFunctionSuite.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1579 1579
Rationale for this change
Convert Spark's built-in function isnan to execute as a native function.
Convert Spark's built-in function nvl2 to execute as a native function.
Convert Spark's built-in function nvl to execute as a native function.
Spark function name:
isnan
nvl2
nvl
Method description:
isnan(expr) - Returns true if expr is NaN, or false otherwise.
nvl2(expr1, expr2, expr3) - Returns expr2 if expr1 is not null, or expr3 otherwise.
Examples:
SELECT isnan(cast('NaN' as double));
true
SELECT nvl2(NULL, 2, 1);
1
SELECT nvl(NULL, array('2'));
["2"]
What changes are included in this PR?
The Spark built-in function nvl2 is converted to
f::math::isnan(),
f::core::nvl2()
f::core::nvl()
Are there any user-facing changes?
How was this patch tested?
UT