[AURON #1849] Introduce native json deserializer#2112
Merged
Tartarus0zm merged 3 commits intoapache:masterfrom Mar 24, 2026
Merged
[AURON #1849] Introduce native json deserializer#2112Tartarus0zm merged 3 commits intoapache:masterfrom
Tartarus0zm merged 3 commits intoapache:masterfrom
Conversation
richox
reviewed
Mar 23, 2026
| output_arrays.push(new_null_array(field.data_type(), array_ref.len())); | ||
| } else { | ||
| output_arrays.push( | ||
| datafusion_ext_commons::arrow::cast::cast(&array_ref, field.data_type()) |
Contributor
There was a problem hiding this comment.
use ? instead of .except(..)
| pub fn new( | ||
| output_schema: SchemaRef, | ||
| nested_msg_mapping: &HashMap<String, String>, | ||
| ) -> datafusion::error::Result<Self> { |
Contributor
There was a problem hiding this comment.
can be simplified with use datafusion::error::Result
Tartarus0zm
force-pushed
the
flink-json-deserializer
branch
from
cb49471 to
2a4ded9
Compare
Contributor
Author
|
@richox I've fixed the issue with the comments. Please take another look. |
richox
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1849
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?
How was this patch tested?