[AURON #2126] Add native support for acosh function#2135
Merged
slfan1989 merged 2 commits intoapache:masterfrom Apr 1, 2026
Merged
[AURON #2126] Add native support for acosh function#2135slfan1989 merged 2 commits intoapache:masterfrom
slfan1989 merged 2 commits intoapache:masterfrom
Conversation
Signed-off-by: weimingdiit <weimingdiit@gmail.com>
Contributor
|
@weimingdiit Thank you for your contribution! Could we add some unit tests? |
Contributor
Author
@slfan1989 Thanks for your comment. I’ve added the ut. Could you please take another look? |
slfan1989
approved these changes
Mar 31, 2026
15 tasks
Contributor
|
@weimingdiit Thanks for the contribution! Merged into the master. |
Contributor
Author
|
@slfan1989 Thanks for your review and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes # #2126
Rationale for this change
Spark Acosh expressions were not wired into Auron’s standard builtin scalar function conversion path, so acosh(expr) could not be planned through the native backend.
This change follows the existing ScalarFunction flow used by other builtin math functions such as acos, asin, and atan: Spark expression conversion in NativeConverters, protobuf enum registration in auron.proto, and planner mapping in planner.rs. This keeps acosh aligned with the current architecture instead of introducing a custom extension function path.
What changes are included in this PR?
This PR:
adds Spark Acosh expression conversion in NativeConverters
introduces ScalarFunction::Acosh in auron.proto
maps ScalarFunction::Acosh in planner.rs
enables acosh(expr) through the standard builtin ScalarFunction chain
Are there any user-facing changes?
No.
How was this patch tested?
CI.