Skip to content

[AURON #2126] Add native support for acosh function#2135

Merged
slfan1989 merged 2 commits intoapache:masterfrom
weimingdiit:feat/add-acosh-function
Apr 1, 2026
Merged

[AURON #2126] Add native support for acosh function#2135
slfan1989 merged 2 commits intoapache:masterfrom
weimingdiit:feat/add-acosh-function

Conversation

@weimingdiit
Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Closes # #2126

Rationale for this change

Spark Acosh expressions were not wired into Auron’s standard builtin scalar function conversion path, so acosh(expr) could not be planned through the native backend.

This change follows the existing ScalarFunction flow used by other builtin math functions such as acos, asin, and atan: Spark expression conversion in NativeConverters, protobuf enum registration in auron.proto, and planner mapping in planner.rs. This keeps acosh aligned with the current architecture instead of introducing a custom extension function path.

What changes are included in this PR?

This PR:

adds Spark Acosh expression conversion in NativeConverters
introduces ScalarFunction::Acosh in auron.proto
maps ScalarFunction::Acosh in planner.rs
enables acosh(expr) through the standard builtin ScalarFunction chain

Are there any user-facing changes?

No.

How was this patch tested?

CI.

Signed-off-by: weimingdiit <weimingdiit@gmail.com>
@weimingdiit weimingdiit marked this pull request as ready for review March 29, 2026 14:10
@slfan1989
Copy link
Copy Markdown
Contributor

@weimingdiit Thank you for your contribution! Could we add some unit tests?

@slfan1989 slfan1989 self-assigned this Mar 30, 2026
Signed-off-by: weimingdiit <weimingdiit@gmail.com>
@weimingdiit
Copy link
Copy Markdown
Contributor Author

@weimingdiit Thank you for your contribution! Could we add some unit tests?

@slfan1989 Thanks for your comment. I’ve added the ut. Could you please take another look?

@slfan1989 slfan1989 merged commit 4b92ce3 into apache:master Apr 1, 2026
123 checks passed
@slfan1989
Copy link
Copy Markdown
Contributor

@weimingdiit Thanks for the contribution! Merged into the master.

@weimingdiit weimingdiit deleted the feat/add-acosh-function branch April 1, 2026 15:02
@weimingdiit
Copy link
Copy Markdown
Contributor Author

@slfan1989 Thanks for your review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants