[AURON #2155] Date-part extraction functions missing timezone handling for Timestamp inputs #2156
Open
ShreyeshArangath wants to merge 4 commits intoapache:masterfrom
Open
[AURON #2155] Date-part extraction functions missing timezone handling for Timestamp inputs #2156ShreyeshArangath wants to merge 4 commits intoapache:masterfrom
ShreyeshArangath wants to merge 4 commits intoapache:masterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2155
Rationale for this change
Five date-part extraction functions in NativeConverters.scala use buildExtScalarFunction, which does not pass the session timezone to the native Rust implementation:
By contrast, Hour, Minute, Second, and WeekOfYear correctly use buildTimePartExt, which passes sessionLocalTimeZone for TimestampType inputs.
This inconsistency can cause incorrect results for timestamp inputs near date boundaries in non-UTC timezones.
Affected functions:
What changes are included in this PR?
This PR fixes the bug described above
Are there any user-facing changes?
Correctness issues fixed
How was this patch tested?
Unit tests