[AURON #2170] Add aggregate suite wrappers for Spark versions#2256
Conversation
|
Hi @slfan1989 , could you help review this PR when convenient? It extends the existing Spark 3.3 aggregate correctness test wrappers to the other supported Spark versions requested in #2170. Thanks very much! |
There was a problem hiding this comment.
Pull request overview
This PR extends Auron’s aggregate correctness test coverage by adding Spark aggregate-suite wrapper classes for additional supported Spark versions (3.1, 3.2, 3.4, 3.5, 4.0, 4.1) and enabling them via each version’s AuronSparkTestSettings, mirroring the existing Spark 3.3 setup.
Changes:
- Added
AuronDataFrameAggregateSuite,AuronDatasetAggregatorSuite, andAuronTypedImperativeAggregateSuitewrappers for Spark 3.1/3.2/3.4/3.5/4.0/4.1 test modules. - Enabled the new suites in each corresponding
AuronSparkTestSettings. - Kept the same DataFrame aggregate suite exclusions as the existing Spark 3.3 wrapper (including excluding the original SPARK-19471 test in favor of the Auron-specific variant).
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| auron-spark-tests/spark31/src/test/scala/org/apache/spark/sql/AuronDataFrameAggregateSuite.scala | Adds Spark 3.1 DataFrame aggregate wrapper with Auron-specific plan assertions for SPARK-19471. |
| auron-spark-tests/spark31/src/test/scala/org/apache/spark/sql/AuronDatasetAggregatorSuite.scala | Adds Spark 3.1 dataset aggregator suite wrapper. |
| auron-spark-tests/spark31/src/test/scala/org/apache/spark/sql/AuronTypedImperativeAggregateSuite.scala | Adds Spark 3.1 typed imperative aggregate suite wrapper. |
| auron-spark-tests/spark31/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables the new aggregate-related suites for Spark 3.1 with matching exclusions. |
| auron-spark-tests/spark32/src/test/scala/org/apache/spark/sql/AuronDataFrameAggregateSuite.scala | Adds Spark 3.2 DataFrame aggregate wrapper with Auron-specific plan assertions for SPARK-19471. |
| auron-spark-tests/spark32/src/test/scala/org/apache/spark/sql/AuronDatasetAggregatorSuite.scala | Adds Spark 3.2 dataset aggregator suite wrapper. |
| auron-spark-tests/spark32/src/test/scala/org/apache/spark/sql/AuronTypedImperativeAggregateSuite.scala | Adds Spark 3.2 typed imperative aggregate suite wrapper. |
| auron-spark-tests/spark32/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables the new aggregate-related suites for Spark 3.2 with matching exclusions. |
| auron-spark-tests/spark34/src/test/scala/org/apache/spark/sql/AuronDataFrameAggregateSuite.scala | Adds Spark 3.4 DataFrame aggregate wrapper with Auron-specific plan assertions for SPARK-19471. |
| auron-spark-tests/spark34/src/test/scala/org/apache/spark/sql/AuronDatasetAggregatorSuite.scala | Adds Spark 3.4 dataset aggregator suite wrapper. |
| auron-spark-tests/spark34/src/test/scala/org/apache/spark/sql/AuronTypedImperativeAggregateSuite.scala | Adds Spark 3.4 typed imperative aggregate suite wrapper. |
| auron-spark-tests/spark34/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables the new aggregate-related suites for Spark 3.4 with matching exclusions. |
| auron-spark-tests/spark35/src/test/scala/org/apache/spark/sql/AuronDataFrameAggregateSuite.scala | Adds Spark 3.5 DataFrame aggregate wrapper with Auron-specific plan assertions for SPARK-19471. |
| auron-spark-tests/spark35/src/test/scala/org/apache/spark/sql/AuronDatasetAggregatorSuite.scala | Adds Spark 3.5 dataset aggregator suite wrapper. |
| auron-spark-tests/spark35/src/test/scala/org/apache/spark/sql/AuronTypedImperativeAggregateSuite.scala | Adds Spark 3.5 typed imperative aggregate suite wrapper. |
| auron-spark-tests/spark35/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables the new aggregate-related suites for Spark 3.5 with matching exclusions. |
| auron-spark-tests/spark40/src/test/scala/org/apache/spark/sql/AuronDataFrameAggregateSuite.scala | Adds Spark 4.0 DataFrame aggregate wrapper with Auron-specific plan assertions for SPARK-19471. |
| auron-spark-tests/spark40/src/test/scala/org/apache/spark/sql/AuronDatasetAggregatorSuite.scala | Adds Spark 4.0 dataset aggregator suite wrapper. |
| auron-spark-tests/spark40/src/test/scala/org/apache/spark/sql/AuronTypedImperativeAggregateSuite.scala | Adds Spark 4.0 typed imperative aggregate suite wrapper. |
| auron-spark-tests/spark40/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables the new aggregate-related suites for Spark 4.0 with matching exclusions. |
| auron-spark-tests/spark41/src/test/scala/org/apache/spark/sql/AuronDataFrameAggregateSuite.scala | Adds Spark 4.1 DataFrame aggregate wrapper with Auron-specific plan assertions for SPARK-19471. |
| auron-spark-tests/spark41/src/test/scala/org/apache/spark/sql/AuronDatasetAggregatorSuite.scala | Adds Spark 4.1 dataset aggregator suite wrapper. |
| auron-spark-tests/spark41/src/test/scala/org/apache/spark/sql/AuronTypedImperativeAggregateSuite.scala | Adds Spark 4.1 typed imperative aggregate suite wrapper. |
| auron-spark-tests/spark41/src/test/scala/org/apache/auron/utils/AuronSparkTestSettings.scala | Enables the new aggregate-related suites for Spark 4.1 with matching exclusions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ShreyeshArangath
left a comment
There was a problem hiding this comment.
LGTM, thanks for working on this. Can you fix the merge conflicts and I'll give you a ✅
e3f36fa to
1faa1ce
Compare
@ShreyeshArangath @slfan1989 Thanks for the review! Conflicts have been resolved. Could you please take another look? |
1faa1ce to
d5cb934
Compare
Which issue does this PR close?
Closes #2170
Rationale for this change
Spark 3.3 already has aggregate correctness test wrappers. This PR extends the same aggregate correctness coverage to the other supported Spark test modules requested by the issue.
What changes are included in this PR?
AuronSparkTestSettings:AuronDataFrameAggregateSuiteAuronDatasetAggregatorSuiteAuronTypedImperativeAggregateSuiteAre there any user-facing changes?
No. This PR only adds test coverage.
How was this patch tested?