Deserializer support for BigDecimal when using apache_avro::serde::bigdecimal#543
Merged
Merged
Conversation
added 2 commits
May 11, 2026 23:21
martin-g
reviewed
May 12, 2026
martin-g
force-pushed
the
jd-fix-big-decimal-bytes
branch
from
ee143cb to
551c09b
Compare
martin-g
reviewed
May 12, 2026
Co-authored-by: Martin Grigorov <martin-g@users.noreply.github.com>
martin-g
approved these changes
May 12, 2026
martin-g
approved these changes
May 15, 2026
Member
|
Thank you, @jdarais ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It looks like serialization/deserialization was made more strict, and in the process, Deserializer no longer supports deserializing BigDecimal as a string, (which is what BigDecimal serializes/deserializes to/from by default.) That's ok, since you can just add
#[serde(with="apache_avro::serde::bigdecimal")], but then it appears that deserializing BigDecimal as bytes is missing. This PR adds the missing support for deserializing BigDecimal as bytes.