[BEAM-500] Finished skeleton of new website layout#31
Closed
francesperry wants to merge 6 commits intoapache:asf-sitefrom
Closed
[BEAM-500] Finished skeleton of new website layout#31francesperry wants to merge 6 commits intoapache:asf-sitefrom
francesperry wants to merge 6 commits intoapache:asf-sitefrom
Conversation
… for files that have changed) and added instructions to README.md
* merged two conflicting organization strategies ('_pages' and 'docs/{use, learn, contribute}' into '{use, learn, contribute, blog, project}'
* created placeholder pages for the remaining things in https://goo.gl/cgFUHf and filed jira issues to fill them in
* standardized multi-word urls/files to use - not _
* added jekyll-redirect-from and redirects for modified links (don't work locally though, since they try to redirect to the live site)
* removed the disclaimer/alert, since it made tests mad and has been replaced by jira links for unwritten content anyway
* temporarily removed the nanthrax link, since it's down (causing test issues)
|
Overall LGTM. Noticed a few things unrelated to this PR which I will open JIRAs for:
|
Member
Author
|
cc: @jbonofre FYI, hope this will merge ok with yours! |
Member
Author
|
@evilsoapbox Any thoughts on the test failures? It's pretty clearly some confusion around the live site not yet having the pages I added. Worst case, I could submit and immediately check it's gone green. |
* Added 'Apache' to Flink/Spark runner pages
Member
Author
|
@evilsoapbox fixed those, thanks! |
|
@francesperry After some tinkering, you can simulate a local build by changing the following in the Of course, this is a hack but it will build the content without the FQDN - when rake it run all paths will be relative and it seems to work OK: |
Member
|
No worries. I will rebase and propose a PR based on this one. |
…s on redirects though.)
… page than in the URL nav bar)
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Jun 5, 2018
melap
pushed a commit
to apache/beam
that referenced
this pull request
Jun 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bunch of website layout changes to follow up on devindonnelly's pr/25
Left all the content/ junk out of this CL. Will regenerate it during the final merge.
Reviewers: @evilsoapbox @dhalperi