[BEAM-514][BEAM-515] Fixed Apache logos and links#33
Merged
asfgit merged 2 commits intoapache:asf-sitefrom Aug 3, 2016
Merged
Conversation
Member
|
R: @jbonofre |
Member
|
LGTM |
Member
Author
|
Oh, thanks JB! Do you want to go ahead and merge it? |
Member
|
Sure, I'm merging now ;) |
Member
|
Just waiting the end of Travis CI. |
| </ul> | ||
| </li> | ||
| <li class="dropdown"> | ||
| <a href="#" class="dropdown-toggle" data-toggle="dropdown" role="button" aria-haspopup="true" aria-expanded="false"><img src="http://www.apache.org/foundation/press/kit/feather_small.png" alt="Apache Logo" style="height:24px;">Apache Software Foundation<span class="caret"></span></a> |
There was a problem hiding this comment.
the img src should begin with //, not http:// -- that will use HTTPS if the current page is HTTPS, and HTTP otherwise. As-is, good browsers will (I believe) warn that insecure resources are included.
There was a problem hiding this comment.
actually could just use https always. No harm in linking secure image into insecure page :)
robertwb
pushed a commit
to robertwb/incubator-beam
that referenced
this pull request
Jun 5, 2018
melap
pushed a commit
to apache/beam
that referenced
this pull request
Jun 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @dhalperi @evilsoapbox