Skip to content

Comments

Minor tweak to Intellij instructions.#494

Closed
tweise wants to merge 2 commits intoapache:asf-sitefrom
tweise:intellij-gradle
Closed

Minor tweak to Intellij instructions.#494
tweise wants to merge 2 commits intoapache:asf-sitefrom
tweise:intellij-gradle

Conversation

@tweise
Copy link

@tweise tweise commented Jul 12, 2018

No description provided.

@tweise tweise requested review from iemejia and jbonofre July 12, 2018 23:33
* Create separate module per source set
* Store generated project files externally
* Use default gradle wrapper
4. Delegate build actions to Gradle by going to Settings > Build, Execution,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems Settings/Preferences is OS specific in linux there is no Preferences and since it is Settings in other lines maybe we let Settings. Apart of this LGTM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this is also version dependent. In 2017.1 I believe it was ... > Build Tools > Gradle

I can confirm that in 2018.1 it is now ... > Build Tools > Gradle > Runner

How about we compromise on Preferences/Settings > Build, Execution, Deployment > Build Tools > Gradle > Runner?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Also I'm testing this with 2017.3 - will mention the Intellij version here as well. Do we need to add anything regarding manual classpath tweaks?

Copy link
Member

@iemejia iemejia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tweise
Copy link
Author

tweise commented Jul 17, 2018

See update. Store generated project files externally is also gone in 2018.1

@lukecwik
Copy link
Member

@asfgit merge

@asfgit asfgit closed this in ef8d164 Jul 17, 2018
swegner pushed a commit to swegner/beam that referenced this pull request Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants