Skip to content

Simplify Flink Runner instructions for running on cluster#99

Closed
aljoscha wants to merge 1 commit intoapache:asf-sitefrom
aljoscha:simplify-flink-quickstart
Closed

Simplify Flink Runner instructions for running on cluster#99
aljoscha wants to merge 1 commit intoapache:asf-sitefrom
aljoscha:simplify-flink-quickstart

Conversation

@aljoscha
Copy link

@aljoscha aljoscha commented Dec 1, 2016

R: @davorbonaci I think this should be simple/straighforward enough now 😃

@asfbot
Copy link

asfbot commented Dec 1, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Test/130/
--none--

@asfbot
Copy link

asfbot commented Dec 1, 2016

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/beam_PreCommit_Website_Stage/173/

Jenkins built the site at commit id 997e045 with Jekyll and staged it here. Happy reviewing.

Note that any previous site has been deleted. This staged site will be automatically deleted after its TTL expires. Push any commit to the pull request branch or re-trigger the build to get it staged again.

Copy link
Member

@davorbonaci davorbonaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

--inputFile=/path/to/quickstart/pom.xml \
--output=/tmp/counts \
--runner=org.apache.beam.runners.flink.FlinkRunner
$ mvn package exec:java -Dexec.mainClass=org.apache.beam.examples.WordCount \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/path/to/quickstart/pom.xml --> pom.xml?
(for consistency)

(the reference target/ is already dependent on the current directory)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it like this because the jar path can be relative to the current directory while inputFile and output file usually are paths to somewhere in a distributed filesystem. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed.

I'm hoping users can copy and paste the command as much as possible. It would be great if they wouldn't need to modify the parameter. So, if this works end-to-end, I'd just use pom.xml. Otherwise, I think your approach is better.

However, this is too-low level point anyways. This PR is an improvement, so I'll merge it. Feel free to push another one if you agree with the change. Otherwise, ignore.

@asfgit asfgit closed this in b6423e5 Dec 2, 2016
@aljoscha aljoscha deleted the simplify-flink-quickstart branch December 2, 2016 23:17
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
robertwb pushed a commit to robertwb/incubator-beam that referenced this pull request Jun 5, 2018
melap pushed a commit to apache/beam that referenced this pull request Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants