-
Notifications
You must be signed in to change notification settings - Fork 15
update travis config based on https://config.travis-ci.com/explore #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.travis.yml
Outdated
| jobs: | ||
| exclude: | ||
| # Exclude the default Python 3.5 build | ||
| - python: 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The python version is 3.5 above but 3.5 is specified as "exclude" here. Is it the reason that making the build skipped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this link might gives the real reason: https://docs.travis-ci.com/user/build-matrix/#explicitly-included-jobs-with-only-one-element-in-the-build-matrix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what this does.
aaltay
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it if it works. I am not sure how to verify travis config changes short of running and seeing it produces the results.
| access_key_id: ${ACCESS_KEY_ID} | ||
| secret_access_key: ${SECRET_ACCESS_KEY} | ||
| bucket: "beam-wheels-staging" | ||
| skip_cleanup: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skip_cleanup is deprecated and it's replacement is cleanup
I should have provided a list of warning messages from https://config.travis-ci.com/explore
.travis.yml
Outdated
| jobs: | ||
| exclude: | ||
| # Exclude the default Python 3.5 build | ||
| - python: 3.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure what this does.
|
This change has fixed the "does not trigger build" problem. |
Thank you! |
Travis-ci now has an online tool to validate travis config: https://config.travis-ci.com/explore.
I updated travis config based on the suggestions from the tool. E.g. fix warnings.