Skip to content

Conversation

@amaliujia
Copy link
Contributor

Travis-ci now has an online tool to validate travis config: https://config.travis-ci.com/explore.

I updated travis config based on the suggestions from the tool. E.g. fix warnings.

@amaliujia
Copy link
Contributor Author

amaliujia commented Apr 2, 2020

@aaltay @boyuanzz

.travis.yml Outdated
jobs:
exclude:
# Exclude the default Python 3.5 build
- python: 3.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The python version is 3.5 above but 3.5 is specified as "exclude" here. Is it the reason that making the build skipped?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this does.

Copy link
Member

@aaltay aaltay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go for it if it works. I am not sure how to verify travis config changes short of running and seeing it produces the results.

access_key_id: ${ACCESS_KEY_ID}
secret_access_key: ${SECRET_ACCESS_KEY}
bucket: "beam-wheels-staging"
skip_cleanup: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

skip_cleanup is deprecated and it's replacement is cleanup

I should have provided a list of warning messages from https://config.travis-ci.com/explore

.travis.yml Outdated
jobs:
exclude:
# Exclude the default Python 3.5 build
- python: 3.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what this does.

@amaliujia amaliujia merged commit 0c52ab9 into apache:master Apr 2, 2020
@amaliujia amaliujia deleted the rw-fix_travis branch April 2, 2020 22:15
@amaliujia
Copy link
Contributor Author

This change has fixed the "does not trigger build" problem.

@aaltay
Copy link
Member

aaltay commented Apr 3, 2020

This change has fixed the "does not trigger build" problem.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants