[BEAM-8570] Use SDK version in default Java container tag #10017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Run XVR_Flink PostCommit |
1 similar comment
Author
|
Run XVR_Flink PostCommit |
ibzib
force-pushed
the
java-container-version
branch
from
5405a84 to
8da47a3
Compare
tvalentyn
approved these changes
Nov 6, 2019
tweise
approved these changes
Nov 7, 2019
ibzib
force-pushed
the
java-container-version
branch
from
8da47a3 to
a9ef293
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One small concern I have is the provenance of the release version. It ultimately comes from
sdk.properties, which is generated by./gradlew :sdks:java:core:processResources, which appears to do nothing unless it's a clean build.Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.