[BEAM-8512] Add integration tests for flink_runner.py.#10284
Merged
mxm merged 5 commits intoapache:masterfrom Dec 18, 2019
Merged
[BEAM-8512] Add integration tests for flink_runner.py.#10284mxm merged 5 commits intoapache:masterfrom
mxm merged 5 commits intoapache:masterfrom
Conversation
Author
|
Run PortableJar_Flink PostCommit |
Also version existing jar creation test.
mxm
reviewed
Dec 9, 2019
Contributor
mxm
left a comment
mxm
left a comment
There was a problem hiding this comment.
Very nice! Having this will make it much easier to make changes to the flink_runner code.
Author
|
Run PortableJar_Flink PostCommit |
Author
|
Run PortableJar_Flink PostCommit |
mxm
approved these changes
Dec 10, 2019
Author
|
Run Seed Job |
1 similar comment
Author
|
Run Seed Job |
Author
|
Run PortableJar_Flink PostCommit |
Contributor
|
This looks ready to be merged. We can observe the new test over time and tune it further. Thank you! |
Author
|
Looks have been intermittent timeouts since this PR. Filed https://issues.apache.org/jira/browse/BEAM-9021 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests will be part of
beam_PostCommit_PortableJar_Flink. Kind of misleading, since as of #10270, portable jars will not actually be used in these tests (they would be expected to fail because of BEAM-8835) but we can use these tests to verify a fix when we have one.Note that we already have
portableWordCountFlinkRunnertests, but those start an embedded Flink cluster so they couldn't testFlinkUberJarJobServer.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.