[BEAM-8424] Revert "[BEAM-4287] Add trySplit API to Java restriction tracker matc…#10295
Closed
lgajowy wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-8424] Revert "[BEAM-4287] Add trySplit API to Java restriction tracker matc…#10295lgajowy wants to merge 1 commit intoapache:masterfrom
lgajowy wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Run Dataflow ValidatesRunner |
lgajowy
changed the title
Contributor
Author
|
After reverting @lukecwik could you take a look? |
Contributor
Author
|
First validates runner suite run that timeouted: https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/3939/ |
Member
|
I have a forward fix in #10301 |
Member
|
If the forward fix doesn't work, feel free to re-open the revert. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…hing Python SDK definition. Remove GetPartition()"
This reverts commit 1ed36b4, reversing
changes made to 5143d40.
The purpose of this PR is to find out if the change affects Java ValidatesRunner tests execution time. The reverted PR seems to be the only one providing changes in java SDK after which the tests started timeouting. I started the Dataflow VR tests to see if they pass without the reverted change.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.