[BEAM-8536] Migrate request_execution_time to request_delay_time in Java#10333
Merged
lukecwik merged 1 commit intoapache:masterfrom Dec 17, 2019
Merged
[BEAM-8536] Migrate request_execution_time to request_delay_time in Java#10333lukecwik merged 1 commit intoapache:masterfrom
lukecwik merged 1 commit intoapache:masterfrom
Conversation
Contributor
Author
|
Run Portable_Python PreCommit |
Contributor
Author
|
Run Java PreCommit |
1 similar comment
Contributor
Author
|
Run Java PreCommit |
Contributor
Author
|
Kindly pinging : ) |
robertwb
reviewed
Dec 16, 2019
Contributor
There was a problem hiding this comment.
Are there other places that need to be changed (e.g. does this need to be a two-phased commit)?
Contributor
Author
There was a problem hiding this comment.
I have changed all usages in this PR. Just talked to Rebo and Daniel, one thing left here is to generate go proto within this PR. I'll let you know once I finish.
Contributor
Author
There was a problem hiding this comment.
I have rebuilt the go proto. Waiting for tests pass.
…delay in DelayedBundleApplication.
boyuanzz
force-pushed
the
patch_again
branch
from
15e1d9e to
18d6fb8
Compare
Contributor
Author
|
Run Java PreCommit |
Member
|
Run Python PreCommit |
lukecwik
approved these changes
Dec 17, 2019
apilloud
reviewed
Dec 19, 2019
|
|
||
| // (Required) The application that should be scheduled. | ||
| BundleApplication application = 2; | ||
| BundleApplication application = 1; |
Member
There was a problem hiding this comment.
Field indexes in protos should never be changed.
Contributor
Author
There was a problem hiding this comment.
Thanks for your comment! I think we should be fine here given:
- The usage of
DelayedBundleApplicationis still under development, we never announced an official supported usage so far IIRC. - We release versioned SDK, which should also work with versioned runner. I don't think it will break anything.
Would you mind explaining a little bit more about your concern?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
+R: @robertwb
cc: @lukecwik