Skip to content

[BEAM-8920] Go SDK: faster transforms/filter.Distinct with CombinePerKey#10349

Merged
lostluck merged 1 commit intoapache:masterfrom
stephydx:distinct
Dec 11, 2019
Merged

[BEAM-8920] Go SDK: faster transforms/filter.Distinct with CombinePerKey#10349
lostluck merged 1 commit intoapache:masterfrom
stephydx:distinct

Conversation

@stephydx
Copy link
Contributor

Replace GroupByKey with CombinePerKey in filter.Distinct, taking advantage of the pre-GBK ParDo to reduce shuffle size.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@stephydx
Copy link
Contributor Author

R: @lostluck

@lostluck
Copy link
Contributor

LGTM

@lostluck lostluck merged commit b7e464b into apache:master Dec 11, 2019
@stephydx stephydx deleted the distinct branch December 11, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants