[BEAM-8801] PubsubMessageToRow should not check useFlatSchema() in pr…#10359
Merged
TheNeuralBit merged 1 commit intoapache:masterfrom Dec 16, 2019
milantracy:beam8801
Merged
[BEAM-8801] PubsubMessageToRow should not check useFlatSchema() in pr…#10359TheNeuralBit merged 1 commit intoapache:masterfrom milantracy:beam8801
TheNeuralBit merged 1 commit intoapache:masterfrom
milantracy:beam8801
Conversation
Contributor
Author
|
R: @TheNeuralBit |
Contributor
|
I will take a look at this PR. @TheNeuralBit for sure is the better reviewer who should have more context. |
Member
|
Run SQL PostCommit |
Member
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
Thanks @milantracy! This looks pretty good overall. The only thing is I really think the inner DoFn classes should be private and I think they can be static as well if we change around the way the schemas are handled.
...est/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubMessageToRowTest.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubMessageToRow.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubMessageToRow.java
Outdated
Show resolved
Hide resolved
Member
TheNeuralBit
left a comment
TheNeuralBit
left a comment
There was a problem hiding this comment.
This looks great, thanks! Just one nit
...est/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubMessageToRowTest.java
Outdated
Show resolved
Hide resolved
...est/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubMessageToRowTest.java
Outdated
Show resolved
Hide resolved
…ocessElement. The PR will make _PubsubMessage_ a **PTransform** instead of DoFn.
amaliujia
approved these changes
Dec 16, 2019
Contributor
|
Run SQL Postcommit |
TheNeuralBit
approved these changes
Dec 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ocessElement.
The PR will make PubsubMessage a PTransform instead of DoFn.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.