[BEAM-8335] Modify PipelineInstrument to add TestStream for unbounded PCollections#10368
Closed
rohdesamuel wants to merge 2 commits intoapache:masterfrom
Closed
[BEAM-8335] Modify PipelineInstrument to add TestStream for unbounded PCollections#10368rohdesamuel wants to merge 2 commits intoapache:masterfrom
rohdesamuel wants to merge 2 commits intoapache:masterfrom
Conversation
davidyan74
reviewed
Dec 12, 2019
sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/pipeline_instrument_test.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/pipeline_instrument_test.py
Outdated
Show resolved
Hide resolved
nika-qubit
reviewed
Dec 12, 2019
sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
Outdated
Show resolved
Hide resolved
nika-qubit
reviewed
Dec 12, 2019
sdks/python/apache_beam/runners/interactive/pipeline_instrument_test.py
Outdated
Show resolved
Hide resolved
nika-qubit
reviewed
Dec 12, 2019
sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
R: @pabloem Hey Pablo, can you review this when you can please? |
Contributor
Author
|
Run Python2_PVR_Flink PreCommit |
davidyan74
approved these changes
Dec 21, 2019
nika-qubit
reviewed
Jan 13, 2020
sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
Outdated
Show resolved
Hide resolved
rohdesamuel
force-pushed
the
streaminginstrument_3
branch
from
e24f308 to
ceaf4a7
Compare
pabloem
reviewed
Jan 22, 2020
Member
pabloem
left a comment
pabloem
left a comment
There was a problem hiding this comment.
Only a few style suggestions. LGTM other than those.
sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
Outdated
Show resolved
Hide resolved
sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
Outdated
Show resolved
Hide resolved
rohdesamuel
force-pushed
the
streaminginstrument_3
branch
from
ceaf4a7 to
4b53792
Compare
Member
|
Run Python PreCommit |
1 similar comment
Member
|
Run Python PreCommit |
Member
|
it looks like the tests are failing @rohdesamuel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @davidyan74
R: @kevingg
#interactive
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.