Skip to content

Forward port Dataflow PR-431, PR-454, PR-453 to Beam#1039

Closed
peihe wants to merge 3 commits intoapache:masterfrom
peihe:forward-port-111
Closed

Forward port Dataflow PR-431, PR-454, PR-453 to Beam#1039
peihe wants to merge 3 commits intoapache:masterfrom
peihe:forward-port-111

Conversation

@peihe
Copy link
Copy Markdown
Contributor

@peihe peihe commented Oct 4, 2016

@peihe peihe force-pushed the forward-port-111 branch from c2bf18e to 14613f4 Compare October 4, 2016 02:40
@peihe
Copy link
Copy Markdown
Contributor Author

peihe commented Oct 4, 2016

Diff for BigQueryTableRowIterator (the deprecated fromQuery is not needed in Beam)

< public class BigQueryTableRowIterator implements AutoCloseable {
---
> class BigQueryTableRowIterator implements AutoCloseable {
124,126c123
<    * specified query in the specified project with useLegacySql set to True.
<    *
<    * @deprecated use {@link #fromQuery(String, String, Bigquery, Boolean, Boolean)}.
---
>    * specified query in the specified project.
128,137d124
<   @Deprecated
<   public static BigQueryTableRowIterator fromQuery(
<       String query, String projectId, Bigquery client, @Nullable Boolean flattenResults) {
<     return fromQuery(query, projectId, client, flattenResults, null /* useLegacySql */);
<   }
< 
<   /**
<      * Constructs a {@code BigQueryTableRowIterator} that reads from the results of executing the
<      * specified query in the specified project.
<      */
166c153
<         // DataflowPipelineRunner.
---
>         // DataflowRunner.
261c248
<       return AvroUtils.formatTimestamp((String) v);
---
>       return BigQueryAvroUtils.formatTimestamp((String) v);
333c320
<         // To match that behavior, BigQueryTableRowiterator, and the DirectPipelineRunner,
---
>         // To match that behavior, BigQueryTableRowiterator, and the DirectRunner,

@peihe peihe force-pushed the forward-port-111 branch from 14613f4 to 3659e99 Compare October 4, 2016 04:20
@peihe peihe changed the title Forward port Dataflow PR-431 to Beam Forward port Dataflow PR-431, PR-454, PR-453 to Beam Oct 4, 2016
@peihe
Copy link
Copy Markdown
Contributor Author

peihe commented Oct 4, 2016

R: @lukecwik
CC: @dhalperi

@peihe peihe force-pushed the forward-port-111 branch from 3659e99 to a558f98 Compare October 4, 2016 17:28
Copy link
Copy Markdown
Member

@lukecwik lukecwik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

queryConfig, MAX_RPC_RETRIES),
Sleeper.DEFAULT,
backoff).getStatistics();
}
Copy link
Copy Markdown
Member

@lukecwik lukecwik Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 298, we don't use INITIAL_JOB_STATUS_POLL_BACKOFF, seems like a backport bug at some point in time. Should be addressed in another PR

@asfgit asfgit closed this in 9b71f16 Oct 6, 2016
@peihe peihe deleted the forward-port-111 branch August 15, 2017 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants