Forward port Dataflow PR-431, PR-454, PR-453 to Beam#1039
Closed
peihe wants to merge 3 commits intoapache:masterfrom
Closed
Forward port Dataflow PR-431, PR-454, PR-453 to Beam#1039peihe wants to merge 3 commits intoapache:masterfrom
peihe wants to merge 3 commits intoapache:masterfrom
Conversation
c2bf18e to
14613f4
Compare
Contributor
Author
|
Diff for BigQueryTableRowIterator (the deprecated fromQuery is not needed in Beam) < public class BigQueryTableRowIterator implements AutoCloseable {
---
> class BigQueryTableRowIterator implements AutoCloseable {
124,126c123
< * specified query in the specified project with useLegacySql set to True.
< *
< * @deprecated use {@link #fromQuery(String, String, Bigquery, Boolean, Boolean)}.
---
> * specified query in the specified project.
128,137d124
< @Deprecated
< public static BigQueryTableRowIterator fromQuery(
< String query, String projectId, Bigquery client, @Nullable Boolean flattenResults) {
< return fromQuery(query, projectId, client, flattenResults, null /* useLegacySql */);
< }
<
< /**
< * Constructs a {@code BigQueryTableRowIterator} that reads from the results of executing the
< * specified query in the specified project.
< */
166c153
< // DataflowPipelineRunner.
---
> // DataflowRunner.
261c248
< return AvroUtils.formatTimestamp((String) v);
---
> return BigQueryAvroUtils.formatTimestamp((String) v);
333c320
< // To match that behavior, BigQueryTableRowiterator, and the DirectPipelineRunner,
---
> // To match that behavior, BigQueryTableRowiterator, and the DirectRunner,
|
14613f4 to
3659e99
Compare
Contributor
Author
3659e99 to
a558f98
Compare
lukecwik
approved these changes
Oct 6, 2016
| queryConfig, MAX_RPC_RETRIES), | ||
| Sleeper.DEFAULT, | ||
| backoff).getStatistics(); | ||
| } |
Member
There was a problem hiding this comment.
On line 298, we don't use INITIAL_JOB_STATUS_POLL_BACKOFF, seems like a backport bug at some point in time. Should be addressed in another PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward port:
GoogleCloudPlatform/DataflowJavaSDK#431
GoogleCloudPlatform/DataflowJavaSDK#454
GoogleCloudPlatform/DataflowJavaSDK#453