[BEAM-8932][Cleanup] Cleanup pubsubio by removing optionality and adding defaults to builders.#10477
Merged
chamikaramj merged 1 commit intoapache:masterfrom Mar 5, 2020
Merged
Conversation
This should have no user-facing effects.
Contributor
Author
|
+R: @chamikaramj |
dpcollins-google
force-pushed
the
cleanup-pubsubio
branch
from
5a2fddc to
b648c97
Compare
|
SUCCESS --none-- |
|
FAILURE --none-- |
dpcollins-google
force-pushed
the
cleanup-pubsubio
branch
from
b648c97 to
5d7a076
Compare
3 tasks
dpcollins-google
force-pushed
the
cleanup-pubsubio
branch
4 times, most recently
from
6161d8c to
5d8b5f5
Compare
Member
|
cc: @chamikaramj |
dpcollins-google
force-pushed
the
cleanup-pubsubio
branch
5 times, most recently
from
77b40c7 to
bd5eeef
Compare
Member
|
retest this please |
dpcollins-google
force-pushed
the
cleanup-pubsubio
branch
2 times, most recently
from
9a39288 to
2bea252
Compare
dpcollins-google
changed the title
Contributor
|
LGTM. Thanks. |
Contributor
|
Retest this please |
Contributor
|
Run Dataflow ValidatesRunner |
Contributor
|
Run Beam PostCommit |
Contributor
|
Run Dataflow ValidatesRunner |
Contributor
|
Run Spotless PreCommit |
Contributor
|
Run RAT PreCommit |
Contributor
|
Run Java_Examples_Dataflow PreCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.