Closed
Conversation
sunjincheng121
commented
Dec 31, 2019
Member
Author
There was a problem hiding this comment.
Hi @lukecwik. Do you think we should add the WireCoderSetting property for each input and output edge explicitly in the proto?
I was thinking the setting is not a necessary properties for each edge so added the wire_coder_settings as an ExecutableStage level property. The wire_coder_settings can be an empty list.
What do you think?
sunjincheng121
force-pushed
the
BEAM-7951-MulInputs
branch
from
765b467 to
2bfd750
Compare
Member
Author
|
I have rebase the code. |
sunjincheng121
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR would address multiple inputs/outputs for wire coder settings as suggested in #9979
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.