Skip to content

[BEAM-8701] Update commons-io to version 2.6#10515

Merged
aromanenko-dev merged 2 commits intoapache:masterfrom
iemejia:BEAM-8701-update-commons-io
Jan 7, 2020
Merged

[BEAM-8701] Update commons-io to version 2.6#10515
aromanenko-dev merged 2 commits intoapache:masterfrom
iemejia:BEAM-8701-update-commons-io

Conversation

@iemejia
Copy link
Member

@iemejia iemejia commented Jan 7, 2020

Removed additionally the unused commons-io 1.x dependency
R: @aromanenko-dev

@iemejia iemejia requested a review from aromanenko-dev January 7, 2020 09:01
@iemejia iemejia force-pushed the BEAM-8701-update-commons-io branch from e01bf92 to 71e16f8 Compare January 7, 2020 09:41
@iemejia
Copy link
Member Author

iemejia commented Jan 7, 2020

Run CommunityMetrics PreCommit

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@aromanenko-dev aromanenko-dev merged commit e2f2bf2 into apache:master Jan 7, 2020
@iemejia iemejia deleted the BEAM-8701-update-commons-io branch January 7, 2020 17:15
@lukecwik
Copy link
Member

lukecwik commented Jan 7, 2020

I would suggest using the linkage checker to verify whether dependency updates will cause linkage errors at runtime. It adds a lot of confidence around whether the change will cause a linkage error during runtime.

See

// Reports linkage errors across multiple Apache Beam artifact ids.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants