[BEAM-5605] Add support for executing pair with restriction, split restriction, split and size restriction, process element and restriction and process sized element and restriction within the Java SDK harness.#10535
Merged
lukecwik merged 2 commits intoapache:masterfrom Jan 10, 2020
Conversation
…striction, split and size restriction, process element and restriction and process sized element and restriction within the Java SDK harness. I removed the SplittableProcessElementsRunner and call the DoFnInvoker directly. I plan to have a follow-up change that removes the "context" object as it is no longer necessary.
Member
Author
|
R: @youngoli |
youngoli
reviewed
Jan 10, 2020
Contributor
youngoli
left a comment
youngoli
left a comment
There was a problem hiding this comment.
Looks pretty good. Only caught one possible issue.
| mainOutputConsumers, | ||
| (WindowedValue<OutputT>) | ||
| WindowedValue.of( | ||
| KV.of(currentElement.getValue(), output), |
Contributor
There was a problem hiding this comment.
Shouldn't this method also produce sizes, like the output method above?
Member
Author
There was a problem hiding this comment.
Yes, fixed in the version below.
I'm relying on the migration to using SDF everywhere will catch the edge cases via the validates runner tests since unit testing the execution of a single instance is quite verbose.
youngoli
approved these changes
Jan 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the SplittableProcessElementsRunner and call the DoFnInvoker directly. I left the SplittableElementsInvoker as is since it is used by non portable SplittableDoFns.
I plan to have a follow-up change that removes the "context" object as it is no longer necessary.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.