-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-9008] Add CassandraIO readAll method #10546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aromanenko-dev
merged 1 commit into
apache:master
from
vmarquez:feature/BEAM-9008/cassandraio_readall
Sep 8, 2021
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
540 changes: 143 additions & 397 deletions
540
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
Large diffs are not rendered by default.
Oops, something went wrong.
83 changes: 83 additions & 0 deletions
83
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ConnectionManager.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.sdk.io.cassandra; | ||
|
|
||
| import com.datastax.driver.core.Cluster; | ||
| import com.datastax.driver.core.Session; | ||
| import java.util.Objects; | ||
| import java.util.concurrent.ConcurrentHashMap; | ||
| import org.apache.beam.sdk.io.cassandra.CassandraIO.Read; | ||
| import org.apache.beam.sdk.options.ValueProvider; | ||
|
|
||
| @SuppressWarnings({ | ||
| "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402) | ||
| }) | ||
| public class ConnectionManager { | ||
|
|
||
| private static final ConcurrentHashMap<String, Cluster> clusterMap = | ||
| new ConcurrentHashMap<String, Cluster>(); | ||
| private static final ConcurrentHashMap<String, Session> sessionMap = | ||
| new ConcurrentHashMap<String, Session>(); | ||
|
|
||
| static { | ||
| Runtime.getRuntime() | ||
| .addShutdownHook( | ||
| new Thread( | ||
| () -> { | ||
| for (Session session : sessionMap.values()) { | ||
| if (!session.isClosed()) { | ||
| session.close(); | ||
| } | ||
| } | ||
| })); | ||
| } | ||
|
|
||
| private static String readToClusterHash(Read<?> read) { | ||
| return Objects.requireNonNull(read.hosts()).get().stream().reduce(",", (a, b) -> a + b) | ||
| + Objects.requireNonNull(read.port()).get() | ||
| + safeVPGet(read.localDc()) | ||
| + safeVPGet(read.consistencyLevel()); | ||
| } | ||
|
|
||
| private static String readToSessionHash(Read<?> read) { | ||
| return readToClusterHash(read) + read.keyspace().get(); | ||
| } | ||
|
|
||
| static Session getSession(Read<?> read) { | ||
| Cluster cluster = | ||
| clusterMap.computeIfAbsent( | ||
| readToClusterHash(read), | ||
| k -> | ||
| CassandraIO.getCluster( | ||
| Objects.requireNonNull(read.hosts()), | ||
| Objects.requireNonNull(read.port()), | ||
| read.username(), | ||
| read.password(), | ||
| read.localDc(), | ||
| read.consistencyLevel(), | ||
| read.connectTimeout(), | ||
| read.readTimeout())); | ||
| return sessionMap.computeIfAbsent( | ||
| readToSessionHash(read), | ||
| k -> cluster.connect(Objects.requireNonNull(read.keyspace()).get())); | ||
| } | ||
|
|
||
| private static String safeVPGet(ValueProvider<String> s) { | ||
| return s != null ? s.get() : ""; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
120 changes: 120 additions & 0 deletions
120
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/ReadFn.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,120 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.beam.sdk.io.cassandra; | ||
|
|
||
| import com.datastax.driver.core.Cluster; | ||
| import com.datastax.driver.core.ColumnMetadata; | ||
| import com.datastax.driver.core.PreparedStatement; | ||
| import com.datastax.driver.core.ResultSet; | ||
| import com.datastax.driver.core.Session; | ||
| import com.datastax.driver.core.Token; | ||
| import java.util.Collections; | ||
| import java.util.Iterator; | ||
| import java.util.Set; | ||
| import java.util.stream.Collectors; | ||
| import org.apache.beam.sdk.io.cassandra.CassandraIO.Read; | ||
| import org.apache.beam.sdk.transforms.DoFn; | ||
| import org.apache.beam.vendor.guava.v26_0_jre.com.google.common.base.Joiner; | ||
| import org.slf4j.Logger; | ||
| import org.slf4j.LoggerFactory; | ||
|
|
||
| @SuppressWarnings({ | ||
| "rawtypes", // TODO(https://issues.apache.org/jira/browse/BEAM-10556) | ||
| "nullness" // TODO(https://issues.apache.org/jira/browse/BEAM-10402) | ||
| }) | ||
| class ReadFn<T> extends DoFn<Read<T>, T> { | ||
|
|
||
| private static final Logger LOG = LoggerFactory.getLogger(ReadFn.class); | ||
|
|
||
| @ProcessElement | ||
| public void processElement(@Element Read<T> read, OutputReceiver<T> receiver) { | ||
| try { | ||
| Session session = ConnectionManager.getSession(read); | ||
| Mapper<T> mapper = read.mapperFactoryFn().apply(session); | ||
| String partitionKey = | ||
| session.getCluster().getMetadata().getKeyspace(read.keyspace().get()) | ||
| .getTable(read.table().get()).getPartitionKey().stream() | ||
| .map(ColumnMetadata::getName) | ||
| .collect(Collectors.joining(",")); | ||
|
|
||
| String query = generateRangeQuery(read, partitionKey, read.ringRanges() != null); | ||
| PreparedStatement preparedStatement = session.prepare(query); | ||
| Set<RingRange> ringRanges = | ||
| read.ringRanges() == null ? Collections.emptySet() : read.ringRanges().get(); | ||
|
|
||
| for (RingRange rr : ringRanges) { | ||
| Token startToken = session.getCluster().getMetadata().newToken(rr.getStart().toString()); | ||
| Token endToken = session.getCluster().getMetadata().newToken(rr.getEnd().toString()); | ||
| ResultSet rs = | ||
| session.execute(preparedStatement.bind().setToken(0, startToken).setToken(1, endToken)); | ||
| Iterator<T> iter = mapper.map(rs); | ||
| while (iter.hasNext()) { | ||
| T n = iter.next(); | ||
| receiver.output(n); | ||
| } | ||
| } | ||
|
|
||
| if (read.ringRanges() == null) { | ||
| ResultSet rs = session.execute(preparedStatement.bind()); | ||
| Iterator<T> iter = mapper.map(rs); | ||
| while (iter.hasNext()) { | ||
| receiver.output(iter.next()); | ||
| } | ||
| } | ||
| } catch (Exception ex) { | ||
| LOG.error("error", ex); | ||
| } | ||
| } | ||
|
|
||
| private Session getSession(Read<T> read) { | ||
| Cluster cluster = | ||
| CassandraIO.getCluster( | ||
| read.hosts(), | ||
| read.port(), | ||
| read.username(), | ||
| read.password(), | ||
| read.localDc(), | ||
| read.consistencyLevel(), | ||
| read.connectTimeout(), | ||
| read.readTimeout()); | ||
|
|
||
| return cluster.connect(read.keyspace().get()); | ||
| } | ||
|
|
||
| private static String generateRangeQuery( | ||
| Read<?> spec, String partitionKey, Boolean hasRingRange) { | ||
| final String rangeFilter = | ||
| (hasRingRange) | ||
| ? Joiner.on(" AND ") | ||
| .skipNulls() | ||
| .join( | ||
| String.format("(token(%s) >= ?)", partitionKey), | ||
| String.format("(token(%s) < ?)", partitionKey)) | ||
| : ""; | ||
| final String combinedQuery = buildInitialQuery(spec, hasRingRange) + rangeFilter; | ||
| LOG.debug("CassandraIO generated query : {}", combinedQuery); | ||
| return combinedQuery; | ||
| } | ||
|
|
||
| private static String buildInitialQuery(Read<?> spec, Boolean hasRingRange) { | ||
| return (spec.query() == null) | ||
| ? String.format("SELECT * FROM %s.%s", spec.keyspace().get(), spec.table().get()) | ||
| + " WHERE " | ||
| : spec.query().get() + (hasRingRange ? " AND " : ""); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.