[BEAM-8337] Fix Flink version munging.#10548
Closed
ibzib wants to merge 1 commit intoapache:release-2.18.0from
Closed
[BEAM-8337] Fix Flink version munging.#10548ibzib wants to merge 1 commit intoapache:release-2.18.0from
ibzib wants to merge 1 commit intoapache:release-2.18.0from
Conversation
Also exit if parsing fails.
udim
reviewed
Jan 10, 2020
| docker push apachebeam/go_sdk:latest | ||
|
|
||
| echo '-------------Generating and Pushing Flink job server images-------------' | ||
| FLINK_VER=("$(ls -1 runners/flink | awk '/^[0-9]+\.[0-9]+$/{print}')") |
Member
There was a problem hiding this comment.
Missing docker rmi for Flink images. (the other file has it)
Author
There was a problem hiding this comment.
The published images are meant to be permanent.
Member
There was a problem hiding this comment.
Look below at lines 81 onwards (I can't comment there because github).
Member
There was a problem hiding this comment.
It's deleting the local images only.
Member
|
Please do this on the master branch, as I run the release scripts from there, and there have been recent relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also exit if parsing fails.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.