[BEAM-8992] Ignore Go Vet failures.#10661
Merged
lostluck merged 1 commit intoapache:masterfrom Jan 22, 2020
Merged
Conversation
Contributor
Author
|
R: @boyuanzz |
boyuanzz
approved these changes
Jan 22, 2020
Contributor
boyuanzz
left a comment
boyuanzz
left a comment
There was a problem hiding this comment.
Thanks for handling this! I'll cherry-pick it into 2.19.0 release branch later.
boyuanzz
pushed a commit
to boyuanzz/beam
that referenced
this pull request
Jan 22, 2020
(cherry picked from commit 8f82927)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we're only seeing the Go Vet failures during releases, then they're happening too late to have anything done about them.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.