[BEAM-9188] CassandraIO split performance improvement - cache size of the table #10701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… table Splitting CassandraIO source into multiple sources works fast as it uses one connection pool to Cassandra cluster but after that dataflow.worker.WorkerCustomSources is calling CassandraSource.getEstimatedSizeBytes for each source which setups and tears down connection to Cassandra cluster to calculate same size of table.
Contributor
|
Retest it please |
Contributor
|
Retest it please |
3 tasks
Contributor
|
Retest it please |
boyuanzz
reviewed
Jan 28, 2020
Contributor
boyuanzz
left a comment
boyuanzz
left a comment
There was a problem hiding this comment.
Thanks for taking care this! Could you please also add unit tests to CassandraIOTest?
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
Outdated
Show resolved
Hide resolved
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
Outdated
Show resolved
Hide resolved
boyuanzz
reviewed
Jan 29, 2020
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
Outdated
Show resolved
Hide resolved
Contributor
|
Retest it please |
stankiewicz
commented
Jan 29, 2020
Contributor
Author
stankiewicz
left a comment
stankiewicz
left a comment
There was a problem hiding this comment.
I've added tests and comments and fixed sizing logic (sum of split sizes roughly equals size of original source)
Contributor
|
Retest it please |
Contributor
Author
|
retest it please |
1 similar comment
Contributor
|
retest it please |
Contributor
|
retest this please |
1 similar comment
Contributor
|
retest this please |
Contributor
|
Java_Examples_Dataflow is broken probably because of dataflow service. |
Contributor
Author
|
retest this please |
1 similar comment
Contributor
|
retest this please |
Contributor
|
Run Spotless PreCommit |
2 similar comments
Contributor
|
Run Spotless PreCommit |
Contributor
|
Run Spotless PreCommit |
Contributor
|
All tests passed. I'll go ahead to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting CassandraIO source into multiple sources works fast as it uses one connection pool to Cassandra cluster but after that dataflow.worker.WorkerCustomSources is calling CassandraSource.getEstimatedSizeBytes for each source which setups and tears down connection to Cassandra cluster to calculate same size of table. This optimization introduces caching of size internally just to avoid additional queries.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.