[BEAM-7516][BEAM-8823] Refactoring FnApiRunner execution logic#10704
Closed
pabloem wants to merge 3 commits intoapache:masterfrom
Closed
[BEAM-7516][BEAM-8823] Refactoring FnApiRunner execution logic#10704pabloem wants to merge 3 commits intoapache:masterfrom
pabloem wants to merge 3 commits intoapache:masterfrom
Conversation
Member
Author
Member
Author
|
r: @robertwb |
robertwb
reviewed
Jan 29, 2020
Contributor
robertwb
left a comment
robertwb
left a comment
There was a problem hiding this comment.
As discussed in person, there may be some larger scale refactorings that we could do here (e.g. finding chunks with good boundaries of abstraction) and possibly creating a full subdirectory for the splitting of this file to go into.
| with self.maybe_profile(): | ||
| pcoll_buffers = collections.defaultdict(_ListBuffer) # type: DefaultDict[bytes, PartitionableBuffer] | ||
| pcoll_buffers = collections.defaultdict( | ||
| fn_api_runner_execution._ListBuffer) # type: DefaultDict[bytes, fn_api_runner_execution._ListBuffer] |
| raise ValueError( | ||
| "Unknown access pattern: '%s'" % si.urn) | ||
|
|
||
| def add_residuals_and_channel_splits_to_deferred_inputs( |
Contributor
There was a problem hiding this comment.
This is one of those methods that doesn't make very much sense out of context. At least add a docstring?
Member
Author
|
closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes the style / refactoring changes related to #10291 - to ideally simplify the review of actual functional changes in #10291.
r: @robertwb
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.