Skip to content

[BEAM-8916] Rename external_test_it so that it is picked up by pytest#10749

Merged
chamikaramj merged 1 commit intoapache:masterfrom
jswarburton:pytest-pick-up-integration-test
Feb 20, 2020
Merged

[BEAM-8916] Rename external_test_it so that it is picked up by pytest#10749
chamikaramj merged 1 commit intoapache:masterfrom
jswarburton:pytest-pick-up-integration-test

Conversation

@jswarburton
Copy link
Contributor

@jswarburton jswarburton commented Feb 3, 2020

Pytest only collects tests matching these patterns:

python_files = test_*.py *_test.py *_test_py3*.py

This test was not being picked up by pytest as a result, so has been renamed to meet the required naming standards.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@jswarburton
Copy link
Contributor Author

@jswarburton
Copy link
Contributor Author

@charlesccychen @aaltay

@jswarburton
Copy link
Contributor Author

Run Python PreCommit

@aaltay aaltay requested a review from chamikaramj February 3, 2020 17:39
Pytest only collects tests matching these patterns:
https://github.com/apache/beam/blob/8066d78f0fd2237b718859d4a776511203880df0/sdks/python/pytest.ini#L27

This test was not being picked up by pytest as a result, so has been renamed to meet the required naming standards.
@charlesccychen
Copy link
Contributor

Run Python Precommit

@charlesccychen
Copy link
Contributor

Run Python Postcommit

@charlesccychen
Copy link
Contributor

Run Python PostCommit

@aaltay
Copy link
Member

aaltay commented Feb 18, 2020

Run Python2_PVR_Flink PreCommit

@chamikaramj
Copy link
Contributor

LGTM. Thanks.

@chamikaramj chamikaramj merged commit 57ce5b9 into apache:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants