[BEAM-8916] Rename external_test_it so that it is picked up by pytest#10749
Merged
chamikaramj merged 1 commit intoapache:masterfrom Feb 20, 2020
jswarburton:pytest-pick-up-integration-test
Merged
[BEAM-8916] Rename external_test_it so that it is picked up by pytest#10749chamikaramj merged 1 commit intoapache:masterfrom jswarburton:pytest-pick-up-integration-test
chamikaramj merged 1 commit intoapache:masterfrom
jswarburton:pytest-pick-up-integration-test
Conversation
Contributor
Author
Contributor
Author
Contributor
Author
|
Run Python PreCommit |
Pytest only collects tests matching these patterns: https://github.com/apache/beam/blob/8066d78f0fd2237b718859d4a776511203880df0/sdks/python/pytest.ini#L27 This test was not being picked up by pytest as a result, so has been renamed to meet the required naming standards.
Contributor
|
Run Python Precommit |
Contributor
|
Run Python Postcommit |
Contributor
|
Run Python PostCommit |
Member
|
Run Python2_PVR_Flink PreCommit |
Contributor
|
LGTM. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pytest only collects tests matching these patterns:
beam/sdks/python/pytest.ini
Line 27 in 8066d78
This test was not being picked up by pytest as a result, so has been renamed to meet the required naming standards.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.