[BEAM-3301] (Go SDK) Adding restriction plumbing to graph construction.#10801
Merged
youngoli merged 1 commit intoapache:masterfrom Feb 8, 2020
Merged
[BEAM-3301] (Go SDK) Adding restriction plumbing to graph construction.#10801youngoli merged 1 commit intoapache:masterfrom
youngoli merged 1 commit intoapache:masterfrom
Conversation
This adds some plumbing that retrieves the restriction type from DoFns, gets a coder for that type, and stores it with ParDos, and ultimately it adds the restriction coder to the translated proto. However, the code for finding the restriction type is unimplemented since we don't have SDFs yet, so this change doesn't do anything concrete yet. Left TODOs as reminders of future work that needs to be done.
Contributor
Author
|
R: @lostluck |
Contributor
|
LGTM. Please merge if the tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some plumbing that retrieves the restriction type from DoFns, gets a coder for that type, and stores it with ParDos, and ultimately it adds the restriction coder to the translated proto. However, the code for finding the restriction type is unimplemented since we don't have SDFs yet, so this change doesn't do anything concrete yet.
Left TODOs as reminders of future work that needs to be done.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.