[BEAM-9160] Removed WebIdentityTokenCredentialsProvider explicit json (de)serialization in AWS module#10836
Closed
ecapoccia wants to merge 1 commit intoapache:masterfrom
ecapoccia:master
Closed
[BEAM-9160] Removed WebIdentityTokenCredentialsProvider explicit json (de)serialization in AWS module#10836ecapoccia wants to merge 1 commit intoapache:masterfrom ecapoccia:master
ecapoccia wants to merge 1 commit intoapache:masterfrom
ecapoccia:master
Conversation
…ider in favor of using the one included in DefaultAWSCredentialsProviderChain
iemejia
changed the title
iemejia
approved these changes
Feb 12, 2020
Member
iemejia
left a comment
iemejia
left a comment
There was a problem hiding this comment.
LGTM Thanks for the extra fix @ecapoccia
iemejia
added a commit
that referenced
this pull request
Feb 12, 2020
…tialsProvider explicit json (de)serialization in AWS module
Member
|
Merged manually to adjust the commit message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #10825 (comment) this changeset eliminates the direct enumeration of WebIdentityTokenCredentialsProvider in the supported identity providers for AWS, as it is already supported via the DefaultAWSCredentialsProviderChain in the latest AWS clients.
It is enabled by specifying
--awsCredentialsProvider={"@type":"DefaultAWSCredentialsProviderChain"}in the AwsOptions.See https://github.com/aws/aws-sdk-java/blob/master/aws-java-sdk-core/src/main/java/com/amazonaws/auth/DefaultAWSCredentialsProviderChain.java#L48 here for the relevant line in the AWS client.