Pin Avro dependency in Python SDK to be consistent with Avro versioning #10851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iemejia
force-pushed
the
beam-python-avro-version
branch
from
4955d66 to
743400a
Compare
tvalentyn
reviewed
Feb 13, 2020
sdks/python/setup.py
Outdated
Contributor
There was a problem hiding this comment.
Can you please add a comment that Avro does not follow semantic versioning, so the second number is the major version, and changes in major versions are not backwards-compatible?
Also I would suggest to target 1.8 range in this change, and make 1.8 -> 1.9 as a separate change.
I know that we attempted to switch to 1.9 in Dataflow in the past and it did not work well: https://issues.apache.org/jira/browse/AVRO-2429 (cc: @chamikaramj).
iemejia
force-pushed
the
beam-python-avro-version
branch
from
743400a to
7fcc92e
Compare
Member
Author
|
Comment added + moved lower bound back to 1.8.1. PTAL @tvalentyn |
aaltay
approved these changes
Feb 14, 2020
Member
|
Run Python PreCommit |
Member
|
Run Portable_Python PreCommit |
Contributor
|
Run Python PreCommit |
Member
Author
|
Thanks for the review @aaltay and @tvalentyn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avro does not follow semver so we should not be automatically upgrade on minor versions.
R: @tvalentyn
CC: @aaltay