Skip to content

Conversation

@y1chi
Copy link
Contributor

@y1chi y1chi commented Feb 14, 2020

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@tvalentyn
Copy link
Contributor

test

@angoenka
Copy link
Contributor

Do we need to make service changes before bumping the fn-api version
The tests are failing with

java.lang.RuntimeException: Failed to create a workflow job: (ae579fdd6a2c2cbb): There is no support for job type STREAMING with environment version 8. Please try upgrading the SDK to the latest version. You can find the instructions on installing the latest SDK at https://cloud.google.com/dataflow/docs/guides/installing-beam-sdk. If that doesn't work, please contact the Cloud Dataflow team for assistance at https://cloud.google.com/dataflow/support.

@y1chi
Copy link
Contributor Author

y1chi commented Feb 26, 2020

Do we need to make service changes before bumping the fn-api version
The tests are failing with

I checked with service team, the job setting change hasn't been rolled out to staging and prod, and a bunch of tests are running with prod setting.

@angoenka
Copy link
Contributor

Retest this please

2 similar comments
@angoenka
Copy link
Contributor

Retest this please

@angoenka
Copy link
Contributor

Retest this please

@angoenka
Copy link
Contributor

Run Java PreCommit

Copy link
Contributor

@angoenka angoenka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@angoenka angoenka merged commit e9cd938 into apache:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants