[BEAM-9352] Align version of transitive jackson dependencies with Beam version#10938
Merged
iemejia merged 2 commits intoFeb 26, 2020
Merged
Conversation
Member
|
Adding the deps to runtimeOnly doesn't fix the generated pom our users will have. Would it make sense to mark them as provided or better yet make them part of the Apache Beam BOM? |
iemejia
force-pushed
the
BEAM-9352-jackson-transitive-consistency
branch
from
8396137 to
1abad3c
Compare
Member
Author
|
You are right, fixed now. I am not really that familiar with Beam's BOM, but can try to tackle this afterwards if we agree that it is a good idea. Opinions on that maybe also @suztomo. |
lukecwik
approved these changes
Feb 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linkage checker analysis
https://gist.github.com/iemejia/9680bd161eeaf36e7a0963c7853f0cbc
R: @lukecwik