[BEAM-9322] Fix tag output names within Dataflow to be consistent with values used in proto.#10971
Merged
lukecwik merged 3 commits intoapache:masterfrom Feb 26, 2020
Merged
[BEAM-9322] Fix tag output names within Dataflow to be consistent with values used in proto.#10971lukecwik merged 3 commits intoapache:masterfrom
lukecwik merged 3 commits intoapache:masterfrom
Conversation
…h values used in proto. This updates the Python SDK to drop 'out'_ and 'out' mangling in favor of using 'None' as the main output when there are more then one output defined otherwise the only output becomes the main output.
Member
Author
|
R: @ananvay @rohdesamuel |
Contributor
|
Thanks a lot Luke! Overall LGTM, assuming the tests pass. |
rohdesamuel
approved these changes
Feb 26, 2020
Contributor
rohdesamuel
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! This is a lot cleaner.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the Python SDK to drop 'out'_ and 'out' mangling in favor of using 'None' as the main output when there are more then one output defined otherwise the only output becomes the main output.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.