Skip to content

[BEAM-9322] Fix tag output names within Dataflow to be consistent with values used in proto.#10971

Merged
lukecwik merged 3 commits intoapache:masterfrom
lukecwik:beam9322
Feb 26, 2020
Merged

[BEAM-9322] Fix tag output names within Dataflow to be consistent with values used in proto.#10971
lukecwik merged 3 commits intoapache:masterfrom
lukecwik:beam9322

Conversation

@lukecwik
Copy link
Member

This updates the Python SDK to drop 'out'_ and 'out' mangling in favor of using 'None' as the main output when there are more then one output defined otherwise the only output becomes the main output.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

…h values used in proto.

This updates the Python SDK to drop 'out'_ and 'out' mangling in favor of using 'None' as the main output when there are more then one output defined otherwise the only output becomes the main output.
@lukecwik
Copy link
Member Author

R: @ananvay @rohdesamuel
CC: @robertwb @aaltay

@ananvay
Copy link
Contributor

ananvay commented Feb 26, 2020

Thanks a lot Luke! Overall LGTM, assuming the tests pass.

Copy link
Contributor

@rohdesamuel rohdesamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! This is a lot cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants