Merged
Conversation
added 3 commits
November 24, 2019 02:38
Signed-off-by: harshit <harshit@pitech.app>
Signed-off-by: harshit <harshit@pitech.app>
… into kotlinWarning
Contributor
|
Please make a single commit out of this |
Contributor
Author
|
Can't you squash these on your end while merging? |
Contributor
|
I can, but then it's up to github (I don't know what will be left of your street cred when it's squached :). If you don't care I can squach. Your sure that the deleted files are obsolete right? |
Contributor
Author
|
Haha, it's alright.
Github will preserve the commit history made by me.
And yeah, the files I deleted were tests that were not needed :)
…On Wed, Feb 26, 2020, 7:18 PM Alex Van Boxel ***@***.***> wrote:
I can, but then it's up to github (I don't know what will be left of your
street cred when it's squached :). If you don't care I can squach. Your
sure that the deleted files are obsolete right?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10976?email_source=notifications&email_token=ALLWCVH3DPZGD4JENJHSRLTREZXL3A5CNFSM4K4CLTRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENAJIAY#issuecomment-591434755>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALLWCVCJCGLYM2ZYEYRVULDREZXL3ANCNFSM4K4CLTRA>
.
|
Member
|
thanks Alex, Harshit! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pabloem @alexvanboxel this PR should eliminate the warnings that started showing up in builds due to the addition of kotlin snippets.
Opened as a replacement of #10204