[BEAM-9444] (Old) Use Google Cloud Libraries BOM to set GCP library dependencies#11125
Closed
suztomo wants to merge 4 commits intoapache:masterfrom
Closed
[BEAM-9444] (Old) Use Google Cloud Libraries BOM to set GCP library dependencies#11125suztomo wants to merge 4 commits intoapache:masterfrom
suztomo wants to merge 4 commits intoapache:masterfrom
Conversation
probot-autolabeler
bot
added
build
dataflow
examples
extensions
gcp
google-cloud-platform-core
io
java
runners
sql
labels
suztomo
commented
Mar 13, 2020
Contributor
Author
There was a problem hiding this comment.
force project.library.java.values() does not take GCP libraries BOM into account. So excluding the versionless coordinates.
suztomo
commented
Mar 13, 2020
Comment on lines
452
to
453
Contributor
Author
There was a problem hiding this comment.
These "google-api-services-" artifacts are not part of GCP Libraries BOM.
Comment on lines
466
to
463
Contributor
Author
There was a problem hiding this comment.
These are not part of GCP Libraries BOM.
Comment on lines
476
to
473
Contributor
Author
There was a problem hiding this comment.
These "google-oauth-client" are not part of GCP Libraries BOM.
Contributor
Author
There was a problem hiding this comment.
bigtable-client-core is not part of GCP Libraries BOM.
suztomo
force-pushed
the
BEAM-9444-gcp-bom
branch
from
15f9781 to
62879ec
Compare
suztomo
force-pushed
the
BEAM-9444-gcp-bom
branch
from
62879ec to
c0919b5
Compare
suztomo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Still in draft)
As per Subject: Proposal: Beam to use GCP Libraries BOM, specifying library versions through GCP Libraries BOM.
Linkage Checker Result
To be pasted.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.