[BEAM-8889]add experiment flag use_grpc_for_gcs #11183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnorigoog
changed the title
vnorigoog
changed the title
vnorigoog
commented
Mar 20, 2020
Contributor
Author
vnorigoog
left a comment
vnorigoog
left a comment
There was a problem hiding this comment.
R: chamikaramj, veblush
veblush
approved these changes
Mar 20, 2020
Contributor
|
Retest this please |
Contributor
|
LGTM. Thanks. |
Contributor
|
Run Java PreCommit |
Contributor
|
Run Java PreCommit |
3 similar comments
Member
|
Run Java PreCommit |
Member
|
Run Java PreCommit |
Contributor
|
Run Java PreCommit |
Member
|
It looks like spotbugs is failing in the Java PreCommit with: |
…nto experiment-flag
…nto experiment-flag
Contributor
Author
|
That is a real problem.
unused variable "gcsOptions"
Thanks, Luke.
could you please issue "Run Java PreCommit" again.
I am trying to understand
1. why local build didn't show this error when spotbugs ran on it.
2. why didn't I see this error on github you saw. I should have. I wonder
if I didn't look in the right place. not happy with myself
…On Tue, Mar 31, 2020 at 4:50 PM Lukasz Cwik ***@***.***> wrote:
It looks like spotbugs is failing in the Java PreCommit with:
Dead store to gcsOptions in org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory.create(PipelineOptions, Storage, HttpRequestInitializer, ExecutorService, Integer)
Bug type DLS_DEAD_LOCAL_STORE (click for details)
In class org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory
In method org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory.create(PipelineOptions, Storage, HttpRequestInitializer, ExecutorService, Integer)
Local variable named gcsOptions
At GcsUtil.java:[line 115]
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11183 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRAMQU6NKEJDI3ZY46PCHTRKJ6T3ANCNFSM4LQRRJQQ>
.
|
Member
|
retest this please |
Member
|
Did you run Also, I had to run the command locally after checking out your PR since the full error log in Jenkins points to a local file on the Jenkins host which isn't accessible. |
Contributor
Author
|
On Tue, Mar 31, 2020 at 7:09 PM Lukasz Cwik ***@***.***> wrote:
Did you run check task of the gradle project to cover
spotbugs/checkstyle/unit tests/... since test only covers testing.
I didn't.
that explains the step I am missing.
thanks
… Also, I had to run the command locally after checking out your PR since
the full error log in Jenkins points to a local file on the Jenkins host
which isn't accessible.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#11183 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALRAMQQEUEJMWXLAJ5U2JHTRKKO55ANCNFSM4LQRRJQQ>
.
|
Member
|
Run JavaPortabilityApi PreCommit |
2 similar comments
Member
|
Run JavaPortabilityApi PreCommit |
Member
|
Run JavaPortabilityApi PreCommit |
Contributor
|
New failure seems to be unrelated. |
Contributor
|
Run JavaPortabilityApi PreCommit |
1 similar comment
Member
|
Run JavaPortabilityApi PreCommit |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, using grpc channel for GCS was controlled by an API change.
Changing that to an experiment, so that there is no need to introduce an API change.
That API change is not in use by anone yet because the underlying change in GCS library to use grpc is not yet public and hence there is no one yet using the new API.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.