[BEAM-9636] Using TimerFamily should also be considered as stateful.#11266
[BEAM-9636] Using TimerFamily should also be considered as stateful.#11266boyuanzz wants to merge 1 commit intoapache:masterfrom
Conversation
|
Run Dataflow ValidatesRunner |
|
Did you want to update the validation in Python as well? |
I think we only need to update the logic where the timer family is actual supported at this moment. But I'll double check. |
|
Run Java PreCommit |
|
Double checked python side. Since we don't have timer family support in python sdk, we should be fine for now. r: @lukecwik |
lukecwik
left a comment
lukecwik
left a comment
There was a problem hiding this comment.
This change looks good and the Python functionality if needed can be added in a separate PR.
|
Run Java PreCommit |
4 similar comments
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
Run Java PreCommit |
|
cc: @robertwb |
|
Run Java PreCommit |
boyuanzz
force-pushed
the
fix_timerfamily
branch
from
e295bdd to
3cdc444
Compare
|
Run Java PreCommit |
| signature.stateDeclarations().isEmpty() | ||
| && signature.timerDeclarations().isEmpty() | ||
| && signature.timerFamilyDeclarations().isEmpty(), | ||
| "SDFs should not have user state/timer."); |
There was a problem hiding this comment.
This does not seem the right place to prohibit this--we should just pass through what is present. (It is true that some runners may not support it (yet?).)
|
#11277 checked in. |
3 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.