-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-9707] Hardcode Unified harness image for fixing dataflow VR 2 t… #11326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run Python Dataflow V2 ValidatesRunner |
|
Thanks Ankur! LGTM. |
|
Run Python Dataflow V2 ValidatesRunner |
robertwb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to be sure to revert this in the release branch after the cut tomorrow.
|
I can add the code to check if the version has dev in it to ensure that its not used in release. |
That makes more sense to me, especially if you were planning on undoing the revert after the cut (?). |
|
Run Python Dataflow V2 ValidatesRunner |
|
updated the PR to only set the image when version is dev. |
|
Run Python Dataflow V2 ValidatesRunner |
|
The failing metric test seems to be working on my local repo https://gradle.com/s/snptwrrxau5we The issue might be the recent changes to beam metric proto cleanup. |
|
Can we loop in Luke and/or sickbay the test to get this PR in? |
|
Had offline discussion with Robert and going ahead with the merge. We will need to sickbay the test or publish a new UW image with the fix which can be done separately. |
…ests
The changes are only temporary till we have 2.21 out. The changes should be reverted before 2.21 is cut.
R: @ananvay @robertwb @lukecwik
cc: @ibzib
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.