Skip to content

Conversation

@angoenka
Copy link
Contributor

@angoenka angoenka commented Apr 6, 2020

…ests

The changes are only temporary till we have 2.21 out. The changes should be reverted before 2.21 is cut.

R: @ananvay @robertwb @lukecwik
cc: @ibzib

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Apex Dataflow Flink Gearpump Samza Spark
Go Build Status --- --- Build Status --- --- Build Status
Java Build Status Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
--- Build Status
Build Status
Build Status
Build Status
Build Status
--- --- Build Status
XLang --- --- --- Build Status --- --- Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website
Non-portable Build Status Build Status
Build Status
Build Status Build Status
Portable --- Build Status --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

@angoenka
Copy link
Contributor Author

angoenka commented Apr 6, 2020

Run Python Dataflow V2 ValidatesRunner

@ananvay
Copy link
Contributor

ananvay commented Apr 6, 2020

Thanks Ankur! LGTM.

@angoenka
Copy link
Contributor Author

angoenka commented Apr 6, 2020

Run Python Dataflow V2 ValidatesRunner

@robertwb robertwb self-requested a review April 7, 2020 19:08
Copy link
Contributor

@robertwb robertwb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need to be sure to revert this in the release branch after the cut tomorrow.

@angoenka
Copy link
Contributor Author

angoenka commented Apr 7, 2020

I can add the code to check if the version has dev in it to ensure that its not used in release.

@ibzib
Copy link

ibzib commented Apr 7, 2020

I can add the code to check if the version has dev in it to ensure that its not used in release.

That makes more sense to me, especially if you were planning on undoing the revert after the cut (?).

@angoenka
Copy link
Contributor Author

angoenka commented Apr 7, 2020

Run Python Dataflow V2 ValidatesRunner

@angoenka
Copy link
Contributor Author

angoenka commented Apr 7, 2020

updated the PR to only set the image when version is dev.

@angoenka
Copy link
Contributor Author

angoenka commented Apr 7, 2020

Run Python Dataflow V2 ValidatesRunner

@angoenka
Copy link
Contributor Author

angoenka commented Apr 7, 2020

The failing metric test seems to be working on my local repo https://gradle.com/s/snptwrrxau5we

The issue might be the recent changes to beam metric proto cleanup.

@ananvay
Copy link
Contributor

ananvay commented Apr 7, 2020

Can we loop in Luke and/or sickbay the test to get this PR in?

@angoenka
Copy link
Contributor Author

angoenka commented Apr 7, 2020

Had offline discussion with Robert and going ahead with the merge. We will need to sickbay the test or publish a new UW image with the fix which can be done separately.

@angoenka angoenka merged commit 1f48ac6 into apache:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants