-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-9678] Create Go SDK introduction kata #11340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I can help to review this as well. |
lostluck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Go code LGTM, bit I'm less familiar with the kata structuring. It feels like we're off by one layer. Someone familiar with the katas more generally can confirm if that matters or not. Consistency by the java or python structures is valuable for others updating things accross the board.
|
@henryken That would be valuable! I'm familiar with Go, and Beam, but not katas. Please chime in! |
henryken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to discuss further about the proposed changes.
learning/katas/go/Introduction/Hello Beam/Hello Beam/task-info.yaml
Outdated
Show resolved
Hide resolved
learning/katas/go/Introduction/Hello Test/Hello Test/test/task_test.go
Outdated
Show resolved
Hide resolved
|
Thank you @henryken. I've changed the PR based on your helpful feedback. |
henryken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes @damondouglas. I have few more comments.
Let me know if you have other thoughts.
learning/katas/go/Introduction/Hello Beam/Hello Beam Test/task.md
Outdated
Show resolved
Hide resolved
learning/katas/go/Introduction/Hello Beam/Hello Beam Test/task.md
Outdated
Show resolved
Hide resolved
henryken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All should be good now. Just one comment below that comes from GoLand suggestion.
|
If everything is okay, I can help to upload this course to Stepik. |
|
@henryken I think everything is ok and if you could help uploading this to Stepik that would be really helpful. I'll email you about hopefully meeting with you to plan out the rest of the katas. |
|
Awesome! @lostluck, please help to merge this PR. Thanks. |
|
Thank you very much! I look forward to the next lessons. This can wait for a next PR, but having a small README on how to keep the go side of the katas up to date (eg commands to run, like go mod tidy or pointers to instructions for how to upload them to stepik) would be valuable for ongoing maintenance and improvement as the SDK has more features added (like Trigger support). I know that when the SDK becomes module compatible and no-longer experimental, we'll definitely need to update these files :) . |
|
There are 2 go.sum files without apache license header, which breaks RAT check. Could you please take a look at it? |
|
There is also no license information in any of the |
|
I think i tried previously and they wouldn't stick on regeneration so I've
already submitted a change to ignore the go.sum files in the license
check. Note that I did ask for licenses to be put on the files earlier, so
i assume you just ran into the same problem i did.
They're important information in that it's checksums for the versions
indicated in the go.mod file, but they're ultimately automatically derived
from files with licenses, so this should be fine.
…On Sat, Apr 18, 2020, 6:30 PM Damon Douglas ***@***.***> wrote:
Thank you for letting me know. 😨 @lostluck <https://github.com/lostluck>
Should we put the license information in the go.sum files? And yes that
README on how to keep the go katas up to date will be helpful. I created
BEAM-9782 <https://issues.apache.org/jira/browse/BEAM-9782> subtask so
its not forgotten.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11340 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKDOFORKN56JIQNUUPYIHLRNJH4DANCNFSM4MDS5PKQ>
.
|
|
I'd need to check but I suspect they're probably getting ignored already?
Yaml is another finicky format.
…On Sat, Apr 18, 2020, 6:34 PM Damon Douglas ***@***.***> wrote:
There is also no license not in any of the *-remote-info.yaml files
either but that didn't break the RAT check? Should we add them there too?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11340 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKDOFNB6WFEY3J6RLNWRLTRNJIJFANCNFSM4MDS5PKQ>
.
|
|
Yes. Already being ignored.
https://github.com/apache/beam/blob/7869455ff38ce4791c5531022ffb75e7f007e06e/build.gradle#L105
I suspect it's more trouble than it's worth to force users who are
refreshing auto generated files to manually reinstate the license which
might interfere with the automatic users of those files.
Community over code.
…On Sat, Apr 18, 2020, 6:35 PM Robert Burke ***@***.***> wrote:
I'd need to check but I suspect they're probably getting ignored already?
Yaml is another finicky format.
On Sat, Apr 18, 2020, 6:34 PM Damon Douglas ***@***.***>
wrote:
> There is also no license not in any of the *-remote-info.yaml files
> either but that didn't break the RAT check? Should we add them there too?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#11340 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADKDOFNB6WFEY3J6RLNWRLTRNJIJFANCNFSM4MDS5PKQ>
> .
>
|
|
Yeah the *-remote-info.yaml files are auto generated and they are overwritten after the course has been uploaded. |
|
I'd suggest we do the same for the go.sum files. |
|
As noted in a previous reply, i already submitted a change to ignore go.sum
files. (It's ok, there were many replies).
https://github.com/apache/beam/blob/7869455ff38ce4791c5531022ffb75e7f007e06e/build.gradle#L77
…On Sun, Apr 19, 2020, 12:15 AM Henry Suryawirawan ***@***.***> wrote:
I'd suggest we do the same for the go.sum files.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11340 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADKDOFNHMT7NHGQDZEWH6G3RNKQJ7ANCNFSM4MDS5PKQ>
.
|
Adds a simple introduction lesson for the Go SDK, to help users get their first pipeline up and running.
This pull request closes BEAM-9678 by adding an Introduction Beam Kata for learning the Go SDK. It patterns after the existing Java and Python Beam Katas.
I would like to request @lostluck to review this PR.
Currently, this PR submits:
Introduction
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.