[BEAM-9778] remove temp directory & add docker-pull-licenses to release scripts#11484
Conversation
Hannah-Jiang
force-pushed
the
license_java_fix
branch
from
18711e3 to
efd6a88
Compare
|
Run XVR_Spark PostCommit |
Hannah-Jiang
changed the title
|
R: @ibzib |
sdks/java/container/build.gradle
Outdated
| } | ||
| } | ||
|
|
||
| def Boolean pull_licenses |
There was a problem hiding this comment.
Why pull this out into a global variable?
There was a problem hiding this comment.
when we pass docker-pull-licenses to :sdks:java:container:docker, generateThirdPartyLicenses task doesn't understand it. In order to pass the tag from docker task to generateThirdPartyLicenses, we need a global value to share it.
There was a problem hiding this comment.
I tried changing generateThirdPartyLicenses to read project.rootProject.hasProperty(["docker-pull-licenses"]) directly, and it seemed to work fine when I called ./gradlew :sdks:java:container:docker -Pdocker-pull-licenses.
There was a problem hiding this comment.
(Sorry for picking nits by the way, I'm just trying to understand Gradle better 😅)
There was a problem hiding this comment.
That was the behavior I observed when I implement it. But yesterday, when I try it again, it didn't work as expected. So I introduced the pull_licenses variable. But today, as you pointed out, I tried again, it worked! I reversed to original code.
|
Run XVR_Spark PostCommit |
|
Run XVR_Flink PostCommit |
|
Run Python PreCommit |
…se scripts (apache#11484) * remove temp dir * add urls for fmpp-0.9.14 and jpam-1.1 * add docker-pull-licenses to release scripts
…se scripts (apache#11484) * remove temp dir * add urls for fmpp-0.9.14 and jpam-1.1 * add docker-pull-licenses to release scripts
2 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.